Re: [Qemu-devel] Re: [PATCH 10/16] scsi: Use 'SCSIRequest' directly

[Hannes Reinecke]

On 11/18/2010 05:16 PM, Gerd Hoffmann wrote:
> On 11/18/10 15:47, Hannes Reinecke wrote:
>>
>> Rather than to access a SCSIRequest via an abstract 'tag' we can
>> as well use it directly and save us the lookup.
> 
> Hmm.  Looks like a few more request handling changes than a pure
> s/tag/req/ + zap lookups sneaked into that patch.  There are new get_req
> and put_req callbacks for example.  At minimum these changes must be
> documented in the commit message.  Even better splitted into separate
> patches.
> 
Not sure if it makes sense to split it up into several patches;
we need the ->get_req()/->put_req() callbacks to get the request in
the first place. And only then can we modify the other callbacks.
However, splitting them off into two patchsets would render the
first pretty much pointless.

But sure, I can do a better description.

Just tell me which direction you prefer.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                   zSeries & Storage
address@hidden                        +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)