[Qemu-devel] Re: [PATCH 0/2] Re: [PATCH v9 5/8] pcie/aer: helper functions for pcie aer capability

[Isaku Yamahata]

On Wed, Nov 17, 2010 at 04:06:38PM +0200, Michael S. Tsirkin wrote:
> On Tue, Nov 16, 2010 at 05:26:09PM +0900, Isaku Yamahata wrote:
> > This patch implements helper functions for pcie aer capability
> > which will be used later.
> > 
> > Signed-off-by: Isaku Yamahata <address@hidden>
> 
> OK, I applied this and tried to get rid of recursion,
> and clean up some whitespace and english mistakes.
> 
> Patcheset attached, pls review.
> 
> I'll push the patches out on pci branch so we can
> make progress more easily.

Thank you for cleaning it up.
Basically looks good. Except the following patch.


> Please, try to address the TODO: I think the case of
> PCIE device behind a pci bridge is not covered properly.

Will do.


>From 166886f7f3e423812f4f3f467e2071c53e9dde01 Mon Sep 17 00:00:00 2001
Message-Id: <address@hidden>
In-Reply-To: <address@hidden>
References: <address@hidden>
From: Isaku Yamahata <address@hidden>
Date: Thu, 18 Nov 2010 17:03:23 +0900
Subject: [PATCH] pcie/aer: typo

Compilation fix.

Signed-off-by: Isaku Yamahata <address@hidden>
---
 hw/pcie_aer.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/hw/pcie_aer.c b/hw/pcie_aer.c
index 03cc6fb..c72cbc6 100644
--- a/hw/pcie_aer.c
+++ b/hw/pcie_aer.c
@@ -363,7 +363,7 @@ static void pcie_aer_msg(PCIDevice *dev, const PCIEAERMsg 
*msg)
     uint8_t type;
 
     while (dev) {
-        if (!pci_is_express(parent_port)) {
+        if (!pci_is_express(dev)) {
             /* just ignore it */
             /* TODO: Shouldn't we set PCI_STATUS_SIG_SYSTEM_ERROR?
              * Consider e.g. a PCI bridge above a PCI Express device. */
-- 
1.7.1.1


-- 
yamahata