[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Force object directory use
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] Force object directory use |
Date: |
Tue, 16 Nov 2010 22:37:44 +0000 |
On 16 November 2010 21:59, Blue Swirl <address@hidden> wrote:
> If the user attempts to run 'configure' in the source tree,
> create an object directory and configure that instead.
>
> Rename topmost Makefile to Makefile.top. Add a new Makefile, which
> is only used when user attempts to run 'make' in the source tree.
[Something seems to have line-wrapped this patch so it won't
apply (not just me, http://patchwork.ozlabs.org/patch/71463/
has line-wrap damage too).]
Minor nit: I think the patch as it stands breaks the "Please
call configure before running make!" user-error guard, doesn't
it?
-- PMM