[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] scsi-disk: Move active request asserts
|
From: |
Kevin Wolf |
|
Subject: |
[Qemu-devel] Re: [PATCH] scsi-disk: Move active request asserts |
|
Date: |
Fri, 12 Nov 2010 11:13:23 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10 |
Am 12.11.2010 10:57, schrieb Stefan Hajnoczi:
> SCSI read/write requests should not be re-issued before the current
> fragment of I/O completes. There are asserts in scsi-disk.c that guard
> this constraint but they trigger on SPARC Linux 2.4. It turns out that
> the asserts are too early in the code path and don't allow for read
> requests to terminate.
>
> Only the read assert needs to be moved but move the write assert too for
> consistency.
>
> Reported-by: Nigel Horne <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
Thanks, applied to the block branch.
Kevin