[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 RESEND] pc: e820 qemu_cfg tables need to be p
|
From: |
Alex Williamson |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 RESEND] pc: e820 qemu_cfg tables need to be packed |
|
Date: |
Wed, 10 Nov 2010 09:09:09 -0700 |
On Sun, 2010-11-07 at 14:59 +0000, Blue Swirl wrote:
> On Fri, Nov 5, 2010 at 9:40 PM, Alex Williamson
> <address@hidden> wrote:
> > We can't let the compiler define the alignment for qemu_cfg data.
>
> Actually, whole e820_table implementation seems to be buggy. The
> structure may not be passed directly to fw_cfg interface without
> endianness conversions, otherwise the emulation will not work on big
> endian host.
I sent a patch for this a couple days ago:
http://lists.nongnu.org/archive/html/qemu-devel/2010-11/msg00481.html
I think that resolves your concern. Thanks,
Alex