[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 1/2] Type-safe ioport callbacks
From: |
Juan Quintela |
Subject: |
[Qemu-devel] Re: [PATCH 1/2] Type-safe ioport callbacks |
Date: |
Mon, 25 Oct 2010 14:54:42 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) |
Avi Kivity <address@hidden> wrote:
> +static void ioport_writeb_thunk(void *opaque, uint32_t addr, uint32_t data)
> +{
> + IOPort *ioport = opaque;
> +
> + return ioport->ops->writeb(ioport, addr, data);
> +}
> +
> +static void ioport_writew_thunk(void *opaque, uint32_t addr, uint32_t data)
> +{
> + IOPort *ioport = opaque;
> +
> + return ioport->ops->writew(ioport, addr, data);
> +}
> +
> +static void ioport_writel_thunk(void *opaque, uint32_t addr, uint32_t data)
> +{
> + IOPort *ioport = opaque;
> +
> + return ioport->ops->writel(ioport, addr, data);
> +}
"return" is not needed on this three functions.
Rest of aproach looks good.
Later, Juan.
- Re: [Qemu-devel] [PATCH 1/2] Type-safe ioport callbacks, (continued)
- Re: [Qemu-devel] [PATCH 1/2] Type-safe ioport callbacks, Avi Kivity, 2010/10/25
- Re: [Qemu-devel] [PATCH 1/2] Type-safe ioport callbacks, Blue Swirl, 2010/10/25
- Re: [Qemu-devel] [PATCH 1/2] Type-safe ioport callbacks, Avi Kivity, 2010/10/26
- Re: [Qemu-devel] [PATCH 1/2] Type-safe ioport callbacks, Blue Swirl, 2010/10/26
- Re: [Qemu-devel] [PATCH 1/2] Type-safe ioport callbacks, Avi Kivity, 2010/10/26
- Re: [Qemu-devel] [PATCH 1/2] Type-safe ioport callbacks, Anthony Liguori, 2010/10/26
- Re: [Qemu-devel] [PATCH 1/2] Type-safe ioport callbacks, Avi Kivity, 2010/10/26
- Re: [Qemu-devel] [PATCH 1/2] Type-safe ioport callbacks, Blue Swirl, 2010/10/26
- Re: [Qemu-devel] [PATCH 1/2] Type-safe ioport callbacks, Avi Kivity, 2010/10/27
- Re: [Qemu-devel] [PATCH 1/2] Type-safe ioport callbacks, Blue Swirl, 2010/10/27
[Qemu-devel] Re: [PATCH 1/2] Type-safe ioport callbacks,
Juan Quintela <=
[Qemu-devel] [PATCH 2/2] piix4 acpi: convert io BAR to type-safe ioport callbacks, Avi Kivity, 2010/10/24
[Qemu-devel] Re: [PATCH 0/2] Type-safe ioport callbacks, Paolo Bonzini, 2010/10/24
Re: [Qemu-devel] [PATCH 0/2] Type-safe ioport callbacks, Anthony Liguori, 2010/10/25
Re: [Qemu-devel] [PATCH 0/2] Type-safe ioport callbacks, Markus Armbruster, 2010/10/25