[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 07/11] block: Use GCC_FMT_ATTR and fix a format erro
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PATCH 07/11] block: Use GCC_FMT_ATTR and fix a format error |
Date: |
Fri, 22 Oct 2010 15:43:52 +0200 |
From: Stefan Weil <address@hidden>
Adding the gcc format attribute detects a format bug
which is fixed here.
v2:
Don't use type cast. BDRV_SECTOR_SIZE is unsigned long long,
so %lld should be the correct format specifier.
Cc: Blue Swirl <address@hidden>
Cc: Kevin Wolf <address@hidden>
Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
---
block/blkverify.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/block/blkverify.c b/block/blkverify.c
index 8083464..b2a12fe 100644
--- a/block/blkverify.c
+++ b/block/blkverify.c
@@ -53,7 +53,8 @@ static AIOPool blkverify_aio_pool = {
.cancel = blkverify_aio_cancel,
};
-static void blkverify_err(BlkverifyAIOCB *acb, const char *fmt, ...)
+static void GCC_FMT_ATTR(2, 3) blkverify_err(BlkverifyAIOCB *acb,
+ const char *fmt, ...)
{
va_list ap;
@@ -299,7 +300,7 @@ static void blkverify_verify_readv(BlkverifyAIOCB *acb)
{
ssize_t offset = blkverify_iovec_compare(acb->qiov, &acb->raw_qiov);
if (offset != -1) {
- blkverify_err(acb, "contents mismatch in sector %ld",
+ blkverify_err(acb, "contents mismatch in sector %lld",
acb->sector_num + (offset / BDRV_SECTOR_SIZE));
}
}
--
1.7.2.3
- [Qemu-devel] [PULL 00/11] Block patches, Kevin Wolf, 2010/10/22
- [Qemu-devel] [PATCH 02/11] qcow2: Simplify image creation, Kevin Wolf, 2010/10/22
- [Qemu-devel] [PATCH 01/11] qcow2: Support exact L1 table growth, Kevin Wolf, 2010/10/22
- [Qemu-devel] [PATCH 03/11] qcow2: Remove old image creation function, Kevin Wolf, 2010/10/22
- [Qemu-devel] [PATCH 04/11] ide: set WCACHE supported in IDENTIFY data, Kevin Wolf, 2010/10/22
- [Qemu-devel] [PATCH 05/11] Copy snapshots out of QCOW2 disk, Kevin Wolf, 2010/10/22
- [Qemu-devel] [PATCH 06/11] qemu-io: New command map, Kevin Wolf, 2010/10/22
- [Qemu-devel] [PATCH 07/11] block: Use GCC_FMT_ATTR and fix a format error,
Kevin Wolf <=
- [Qemu-devel] [PATCH 09/11] ide: Factor ide_flush_cache out, Kevin Wolf, 2010/10/22
- [Qemu-devel] [PATCH 10/11] ide: Handle flush failure, Kevin Wolf, 2010/10/22
- [Qemu-devel] [PATCH 08/11] qemu-img: Fix qemu-img convert -obacking_file, Kevin Wolf, 2010/10/22
- [Qemu-devel] [PATCH 11/11] virtio-blk: Respect werror option for flushes, Kevin Wolf, 2010/10/22