[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH v6 08/12] pcie/aer: helper functions for pcie ae
From: |
Isaku Yamahata |
Subject: |
[Qemu-devel] Re: [PATCH v6 08/12] pcie/aer: helper functions for pcie aer capability |
Date: |
Thu, 21 Oct 2010 14:15:24 +0900 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
Thank you for detailed review.
On Wed, Oct 20, 2010 at 11:56:16AM +0200, Michael S. Tsirkin wrote:
> > +static uint32_t aer_log_del(PCIEAERLog *aer_log)
> > +{
> > + uint32_t i = aer_log->consumer;
> > + aer_log->consumer = aer_log_next(aer_log->consumer, aer_log->log_max);
> > + return i;
> > +}
>
>
> Please just use 'int' or 'unsigned' instead of uint32_t if you simply
> want to say 'a number'. Using specific length makes it impossible to
> say where you *really* want a value.
PCIEAERLog is saved/loaded. So explicit sized number is chosen.
--
yamahata
[Qemu-devel] [PATCH v6 05/12] x3130: pcie upstream port, Isaku Yamahata, 2010/10/20
[Qemu-devel] [PATCH v6 09/12] pcie/aer: glue aer error injection into qemu monitor, Isaku Yamahata, 2010/10/20
[Qemu-devel] [PATCH v6 02/12] pci/bridge: fix pci_bridge_reset(), Isaku Yamahata, 2010/10/20