qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH v3 0/9] Re-factor osdep code + macro and brace f


From: Paolo Bonzini
Subject: [Qemu-devel] Re: [PATCH v3 0/9] Re-factor osdep code + macro and brace fixes
Date: Mon, 18 Oct 2010 11:08:38 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100907 Fedora/3.1.3-1.fc13 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.3

On 10/18/2010 10:15 AM, address@hidden wrote:
From: Jes Sorensen<address@hidden>

Hi,

Here is another set of patches which tries to split up osdep.c further
into posix and win32 versions. It introduces oslib-{posix,win32}.c
files which are used for functions that are OS specific core library
functionality, like gettimeofday(), and which is used by both QEMU and
support applications like qemu-img. Other functions are moved to
os-{posix,win32}.c. In addtion there are a couple of minor fixes for
bad macro names.

In some cases braces were added to code when it was moved, to make it
compliant with the QEMU bracing rules.

v3 fixes the issues pointed out by Blue Swirl, notably it moves the
win32 ffs prototype to qemu-common.h which is consistent with it being
provided by strings.h for POSIX, and fixes linking of linux-user.

Cheers,
Jes

Jes Sorensen (9):
   Move QEMU OS dependant library functions to OS specific files
   Move osdep socket code to oslib-{posix,win32}.c
   qemu_pipe() is used only by POSIX code, so move to oslib-posix.c
   We only support eventfd under POSIX, move qemu_eventfd() to
     os-posix.c
   Move qemu_gettimeofday() to OS specific files
   Do not redefine reserved key-words TRUE/FALSE
   Separate qemu_pidfile() into OS specific versions
   Consolidate oom_check() functions
   Remove unncessary includes

  Makefile           |    6 +-
  Makefile.objs      |    9 ++-
  Makefile.target    |    2 +-
  hw/bt-sdp.c        |   20 ++--
  os-posix.c         |   53 +++++++++++
  os-win32.c         |   24 +++++
  osdep.c            |  256 ----------------------------------------------------
  osdep.h            |   15 ---
  oslib-posix.c      |  109 ++++++++++++++++++++++
  oslib-win32.c      |  121 +++++++++++++++++++++++++
  posix-aio-compat.c |    1 +
  qemu-common.h      |    6 ++
  qemu-img.c         |    1 +
  qemu-malloc.c      |   14 +---
  qemu-os-posix.h    |    3 +
  qemu-os-win32.h    |    8 ++
  qemu-tool.c        |    1 +
  17 files changed, 352 insertions(+), 297 deletions(-)
  create mode 100644 oslib-posix.c
  create mode 100644 oslib-win32.c


ACK

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]