[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/7] Switch migrate_set_speed() to take an 'o' a
From: |
Jes Sorensen |
Subject: |
Re: [Qemu-devel] [PATCH 5/7] Switch migrate_set_speed() to take an 'o' argument rather than a float. |
Date: |
Mon, 11 Oct 2010 11:58:43 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100921 Fedora/3.1.4-1.fc13 Lightning/1.0b3pre Thunderbird/3.1.4 |
On 10/11/10 11:03, Markus Armbruster wrote:
>
> As noted before, this is an incompatible change of the human monitor
> command: unit now defaults to 'M'. This must be noted *prominently* in
> the commit message. Best in the subject.
>
> Incompatible changes can break tools. Quick grep of libvirt:
>
> src/qemu/qemu_monitor_json.c: cmd =
> qemuMonitorJSONMakeCommand("migrate_set_speed",
> src/qemu/qemu_monitor_text.c: if (virAsprintf(&cmd, "migrate_set_speed
> %lum", bandwidth) < 0) {
>
> Looks like we're safe here.
>
> Anthony, is this incompatibility okay?
I agree it is incompatible, however it was a conscious decision to get
rid of the inconsistency we had around various places for these types of
arguments. If there is strong opposition to this change, then I can
mangle the interface to allow for the old, but IMHO bad, default of the
monitor.
> Help should be updated in the same patch; please squash 6/7 into 5/7.
Ok will do.
Cheers,
Jes
- Re: [Qemu-devel] [PATCH 1/7] Introduce strtosz() library function to convert a string to a byte count., (continued)
[Qemu-devel] [PATCH 2/7] Support human unit formats in strtosz, eg. 1.0G, Jes . Sorensen, 2010/10/08
[Qemu-devel] [PATCH 3/7] Add more error handling to strtosz(), Jes . Sorensen, 2010/10/08
[Qemu-devel] [PATCH 4/7] Add support for 'o' octet (bytes) format as monitor parameter., Jes . Sorensen, 2010/10/08
[Qemu-devel] [PATCH 5/7] Switch migrate_set_speed() to take an 'o' argument rather than a float., Jes . Sorensen, 2010/10/08
[Qemu-devel] [PATCH 6/7] Clarify default values in migration speed argument in monitor, Jes . Sorensen, 2010/10/08
[Qemu-devel] [PATCH 7/7] Remove obsolete 'f' double parameter type, Jes . Sorensen, 2010/10/08