[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] fix unsigned comparison warning in TCG
From: |
Venkateswararao Jujjuri (JV) |
Subject: |
Re: [Qemu-devel] fix unsigned comparison warning in TCG |
Date: |
Thu, 07 Oct 2010 16:15:16 -0700 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.9) Gecko/20100915 Thunderbird/3.1.4 |
On 9/26/2010 11:33 AM, Blue Swirl wrote:
> On Sun, Sep 26, 2010 at 5:40 PM, Hollis Blanchard <address@hidden> wrote:
>> TCGOpcode is an enum, which apparently can be unsigned.
>>
>> Signed-off-by: Hollis Blanchard <address@hidden>
>> ---
>>
>> % ./configure --target-list=ppcemb-softmmu --enable-debug
>> % make
>> ...
>> CC ppcemb-softmmu/tcg/tcg.o
>> cc1: warnings being treated as errors
>> /home/hollisb/source/qemu.git/tcg/tcg.c: In function
>> ‘tcg_add_target_add_op_defs’:
>> /home/hollisb/source/qemu.git/tcg/tcg.c:1030: error: comparison of
>> unsigned expression >= 0 is always true
>> % gcc -v
>> gcc version 4.4.4 20100630 (Red Hat 4.4.4-10) (GCC)
>>
>> diff --git a/tcg/tcg.c b/tcg/tcg.c
>> index e0a9030..7e96859 100644
>> --- a/tcg/tcg.c
>> +++ b/tcg/tcg.c
>> @@ -1027,7 +1027,7 @@ void tcg_add_target_add_op_defs(const TCGTargetOpDef
>> *tdef
>> if (tdefs->op == (TCGOpcode)-1)
>> break;
>> op = tdefs->op;
>> - assert(op >= 0 && op < NB_OPS);
>> + assert(op < NB_OPS);
>
> Please add int cast, like 95ee3914bfd551aeec49932a400530141865acad.
>
What is the latest on this? Waiting for this fix as I use --enable-debug a lot.
:)
- JV
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] fix unsigned comparison warning in TCG,
Venkateswararao Jujjuri (JV) <=