[Qemu-devel] Re: [PATCH 1/3] Make kvm64 the default cpu model when kvm_enabled()

[Roedel, Joerg]

On Wed, Oct 06, 2010 at 03:24:59PM -0400, Anthony Liguori wrote:
> >> +    qemu_compat_version = machine->compat_version;
> >> +
> >>       if (display_type == DT_NOGRAPHIC) {
> >>           if (default_parallel)
> >>               add_device_config(DEV_PARALLEL, "null");
> >> -- 
> >> 1.7.0.4
> >>      
> > Looks fine to me, given CPUs are not in qdev. Anthony?
> >    
> 
> The idea is fine, but why not just add the default CPU to the machine 
> description?

If I remember correctly the reason was that the machine description was
not accessible in the cpuid initialization path because it is a function
local variable. I could have made it a global variable but considered
the compat_version approach simpler. The qemu_compat_version might also
be useful at other places.

        Joerg

-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632