[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 04/11] lsi53c895a: avoid a write only variable
From: |
Blue Swirl |
Subject: |
[Qemu-devel] [PATCH 04/11] lsi53c895a: avoid a write only variable |
Date: |
Wed, 6 Oct 2010 21:32:46 +0000 |
Compiling with GCC 4.6.0 20100925 produced a warning:
/src/qemu/hw/lsi53c895a.c: In function 'lsi_do_msgout':
/src/qemu/hw/lsi53c895a.c:848:9: error: variable 'len' set but not
used [-Werror=unused-but-set-variable]
Fix by making the variable declaration and its uses also conditional
to debug definition.
Signed-off-by: Blue Swirl <address@hidden>
---
hw/lsi53c895a.c | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/hw/lsi53c895a.c b/hw/lsi53c895a.c
index 5eaf69e..db28f06 100644
--- a/hw/lsi53c895a.c
+++ b/hw/lsi53c895a.c
@@ -845,8 +845,9 @@ static uint8_t lsi_get_msgbyte(LSIState *s)
static void lsi_do_msgout(LSIState *s)
{
uint8_t msg;
+#ifdef DEBUG_LSI
int len;
-
+#endif
DPRINTF("MSG out len=%d\n", s->dbc);
while (s->dbc) {
msg = lsi_get_msgbyte(s);
@@ -862,7 +863,11 @@ static void lsi_do_msgout(LSIState *s)
lsi_set_phase(s, PHASE_CMD);
break;
case 0x01:
+#ifdef DEBUG_LSI
len = lsi_get_msgbyte(s);
+#else
+ (void)lsi_get_msgbyte(s);
+#endif
msg = lsi_get_msgbyte(s);
DPRINTF("Extended message 0x%x (len %d)\n", msg, len);
switch (msg) {
--
1.6.2.4
- [Qemu-devel] [PATCH 04/11] lsi53c895a: avoid a write only variable,
Blue Swirl <=