[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 02/19] QMP: handle_qmp_command(): Move 'cmd' sanity
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] [PATCH 02/19] QMP: handle_qmp_command(): Move 'cmd' sanity check |
Date: |
Thu, 30 Sep 2010 17:56:03 -0300 |
Next commit will change how query commands are handled in a
way that the 'cmd' sanity check is also going to be needed
for query commands handling.
Let's move it out of the else body then.
Signed-off-by: Luiz Capitulino <address@hidden>
---
monitor.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/monitor.c b/monitor.c
index 5aead4f..8324e65 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4372,11 +4372,11 @@ static void handle_qmp_command(JSONMessageParser
*parser, QList *tokens)
qobject_from_jsonf("{ 'item': %s }", info_item));
} else {
cmd = monitor_find_command(cmd_name);
- if (!cmd || !monitor_handler_ported(cmd)
- || monitor_cmd_user_only(cmd)) {
- qerror_report(QERR_COMMAND_NOT_FOUND, cmd_name);
- goto err_out;
- }
+ }
+
+ if (!cmd || !monitor_handler_ported(cmd) || monitor_cmd_user_only(cmd)) {
+ qerror_report(QERR_COMMAND_NOT_FOUND, cmd_name);
+ goto err_out;
}
obj = qdict_get(input, "arguments");
--
1.7.3.1.45.g9855b
- [Qemu-devel] [PATCH v2 00/19] Monitor: split HMP and QMP dispatch tables, Luiz Capitulino, 2010/09/30
- [Qemu-devel] [PATCH 01/19] Monitor: Introduce search_dispatch_table(), Luiz Capitulino, 2010/09/30
- [Qemu-devel] [PATCH 02/19] QMP: handle_qmp_command(): Move 'cmd' sanity check,
Luiz Capitulino <=
- [Qemu-devel] [PATCH 03/19] QMP: Don't use do_info(), Luiz Capitulino, 2010/09/30
- [Qemu-devel] [PATCH 04/19] Monitor: Drop QMP bits from do_info(), Luiz Capitulino, 2010/09/30
- [Qemu-devel] [PATCH 05/19] Monitor: Drop is_async_return(), Luiz Capitulino, 2010/09/30
- [Qemu-devel] [PATCH 06/19] Monitor: Convert do_info() back to HMP, Luiz Capitulino, 2010/09/30
- [Qemu-devel] [PATCH 07/19] Monitor: Introduce the qmp-commands.hx file, Luiz Capitulino, 2010/09/30
- [Qemu-devel] [PATCH 09/19] QMP: Introduce command dispatch table, Luiz Capitulino, 2010/09/30
- [Qemu-devel] [PATCH 08/19] QMP: Introduce qmp_find_cmd(), Luiz Capitulino, 2010/09/30
- [Qemu-devel] [PATCH 10/19] QMP: Introduce query commands dispatch table, Luiz Capitulino, 2010/09/30
- [Qemu-devel] [PATCH 12/19] QMP: Small cleanup in handle_qmp_command(), Luiz Capitulino, 2010/09/30
- [Qemu-devel] [PATCH 11/19] QMP: Simplify do_info_commands(), Luiz Capitulino, 2010/09/30