[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH] blkverify: Handle overlapping I/O vector bu
Re: [Qemu-devel] Re: [PATCH] blkverify: Handle overlapping I/O vector buffers
Tue, 21 Sep 2010 11:43:33 +0100
On Tue, Sep 21, 2010 at 11:06 AM, Kevin Wolf <address@hidden> wrote:
> Am 20.09.2010 15:31, schrieb Stefan Hajnoczi:
>> When blkverify clones an I/O vector in order to perform mirrored reads
>> and then compare their contents, it does not take into account the
>> layout of individual buffers. It turns out this is important because
>> guests may issue requests with overlapping buffers and the results
>> differ depending on how buffers are overlapped.
>> This patch introduces logic to honor overlap relationships when cloning
>> I/O vectors.
>> Signed-off-by: Stefan Hajnoczi <address@hidden>
> Took me a while to review this. These buffer calculations always look so
> harmless, but it's not trivial at all...
Thanks for the review! I wasn't thrilled to add this logic either but
I don't see a way around it.
Will merge into blkverify so there is one unified patch including
fixes for your review comments.