[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH v6] Introduce qemu_madvise()
From: |
Blue Swirl |
Subject: |
[Qemu-devel] Re: [PATCH v6] Introduce qemu_madvise() |
Date: |
Wed, 15 Sep 2010 19:50:53 +0000 |
On Wed, Sep 15, 2010 at 7:35 PM, Andreas Färber <address@hidden> wrote:
> Am 15.09.2010 um 21:00 schrieb Blue Swirl:
>
>> madvise() actually
>> returns 0 or -1 with error code in errno. Should we try to match that?
>
> posix_madvise() doesn't seem to... "otherwise, an error number shall be
> returned to indicate the error"
If we match posix_madvise(), then the wrapper function probably should
become qemu_posix_madvise() and we should prefer posix_madvise() over
madvise().
> It documents EINVAL for invalid advice, and so does madvise. Are we using
> ENOTSUP knowingly?
Let's use EINVAL.
> Maybe return -1 and set errno to the posix_madvise() return code? (but is it
> errno = -retval or errno = retval then?)
An advantage of posix_madvise() semantics is that no mucking with
errno is needed. Though existing code should be checked if they rely
on madvise() semantics instead.
- [Qemu-devel] [RFC v4] Introduce qemu_madvise(), (continued)
- [Qemu-devel] [RFC v4] Introduce qemu_madvise(), Andreas Färber, 2010/09/13
- [Qemu-devel] Re: [RFC v4] Introduce qemu_madvise(), Blue Swirl, 2010/09/14
- [Qemu-devel] Re: [RFC v4] Introduce qemu_madvise(), Alexander Graf, 2010/09/14
- [Qemu-devel] Re: [RFC v4] Introduce qemu_madvise(), Blue Swirl, 2010/09/14
- [Qemu-devel] [PATCH v5] Introduce qemu_madvise(), Andreas Färber, 2010/09/14
- [Qemu-devel] Re: [PATCH v5] Introduce qemu_madvise(), Blue Swirl, 2010/09/14
- [Qemu-devel] Re: [PATCH v5] Introduce qemu_madvise(), Andreas Färber, 2010/09/14
- [Qemu-devel] [PATCH v6] Introduce qemu_madvise(), Andreas Färber, 2010/09/15
- [Qemu-devel] Re: [PATCH v6] Introduce qemu_madvise(), Blue Swirl, 2010/09/15
- [Qemu-devel] Re: [PATCH v6] Introduce qemu_madvise(), Andreas Färber, 2010/09/15
- [Qemu-devel] Re: [PATCH v6] Introduce qemu_madvise(),
Blue Swirl <=
- [Qemu-devel] Re: [PATCH v6] Introduce qemu_madvise(), Andreas Färber, 2010/09/15
- [Qemu-devel] [PATCH v7] Introduce qemu_madvise(), Andreas Färber, 2010/09/19
- [Qemu-devel] Re: [PATCH v7] Introduce qemu_madvise(), Blue Swirl, 2010/09/20
- Re: [Qemu-devel] Re: [PATCH v7] Introduce qemu_madvise(), Andreas Färber, 2010/09/24
- Re: [Qemu-devel] Re: [PATCH v7] Introduce qemu_madvise(), Blue Swirl, 2010/09/25
- [Qemu-devel] [PATCH v8] Introduce qemu_madvise(), Andreas Färber, 2010/09/25
- [Qemu-devel] Re: [PATCH v8] Introduce qemu_madvise(), Blue Swirl, 2010/09/25