|
From: | Juan Quintela |
Subject: | [Qemu-devel] Re: [PATCH 2/5] Support human unit formats in strtobytes, eg. 1.0G |
Date: | Wed, 15 Sep 2010 16:50:40 +0200 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) |
address@hidden wrote: > From: Jes Sorensen <address@hidden> > value <<= 10; > break; > case 0: > + if (divider) { > + value = 0; > + break; changing break by goto fail here? 1.5G and 1.0G is ok, but using 1024.00 or similar should be one error, no? nice cleanup for the rest of the patch series. Later, Juan. > + } > case 'M': > case 'm': > value <<= 20;
[Prev in Thread] | Current Thread | [Next in Thread] |