[Qemu-devel] Re: [PATCH] trace: Fix user emulator dependency on trace objects

[Stefan Hajnoczi]

On Sun, Sep 12, 2010 at 05:21:36PM +0200, Andreas Färber wrote:
> On a clean build, after generating trace.h, make would recurse into *-*-user
> without a clue how to build ../trace.o (added to $(obj-y) in Makefile.target)
> since its generation rule is in the main Makefile.
> The softmmus are seemingly unaffected because the $(TOOLS), which each have
> a dependency on $(trace-obj-y), are built first for the build-all target.
> 
> Add a dependency on $(trace-obj-y) for %-user, as done for the qemu-* tools.
> 
> Let's be paranoid and do the same for %-softmmu while at it, just in case
> someone messes with $(TOOLS) or calls the Makefile target directly.
> 
> Signed-off-by: Andreas Färber <address@hidden>
> Cc: Stefan Hajnoczi <address@hidden>
> Cc: Prerna Saxena <address@hidden>
> Cc: Blue Swirl <address@hidden>
> Cc: Anthony Liguori <address@hidden>
> ---
>  Makefile |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

Thanks for the patch!

Stefan