[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] Disable virtio-balloon memory stats interface
From: |
Adam Litke |
Subject: |
[Qemu-devel] [PATCH] Disable virtio-balloon memory stats interface |
Date: |
Wed, 8 Sep 2010 09:21:16 -0500 |
The addition of memory stats reporting to the virtio balloon causes
the 'info balloon' command to become asynchronous. This is a regression
because in some cases it can hang the user monitor.
Disable this feature until a better interface for asynchronous commands
can be worked out.
Signed-off-by: Adam Litke <address@hidden>
---
hw/virtio-balloon.c | 12 +++++++++++-
1 files changed, 11 insertions(+), 1 deletions(-)
diff --git a/hw/virtio-balloon.c b/hw/virtio-balloon.c
index 9fe3886..dcdada6 100644
--- a/hw/virtio-balloon.c
+++ b/hw/virtio-balloon.c
@@ -190,7 +190,17 @@ static void virtio_balloon_set_config(VirtIODevice *vdev,
static uint32_t virtio_balloon_get_features(VirtIODevice *vdev, uint32_t f)
{
- f |= (1 << VIRTIO_BALLOON_F_STATS_VQ);
+ /*
+ * The addition of memory stats reporting to the virtio balloon causes
+ * the 'info balloon' command to become asynchronous. This is a regression
+ * because in some cases it can hang the user monitor.
+ *
+ * Disable this feature until a better interface for asynchronous commands
+ * can be worked out.
+ *
+ * -aglitke
+ */
+ /* f |= (1 << VIRTIO_BALLOON_F_STATS_VQ); */
return f;
}
--
1.6.1.3
- [Qemu-devel] [PATCH] Disable virtio-balloon memory stats interface,
Adam Litke <=
- Re: [Qemu-devel] [PATCH] Disable virtio-balloon memory stats interface, Eduardo Habkost, 2010/09/14
- Re: [Qemu-devel] [PATCH] Disable virtio-balloon memory stats interface, Adam Litke, 2010/09/14
- Re: [Qemu-devel] [PATCH] Disable virtio-balloon memory stats interface, Eduardo Habkost, 2010/09/14
- Re: [Qemu-devel] [PATCH] Disable virtio-balloon memory stats interface, Eduardo Habkost, 2010/09/14
- Re: [Qemu-devel] [PATCH] Disable virtio-balloon memory stats interface, Luiz Capitulino, 2010/09/14
- Re: [Qemu-devel] [PATCH] Disable virtio-balloon memory stats interface, Adam Litke, 2010/09/14
- Re: [Qemu-devel] [PATCH] Disable virtio-balloon memory stats interface, Luiz Capitulino, 2010/09/14
Re: [Qemu-devel] [PATCH] Disable virtio-balloon memory stats interface, Adam Litke, 2010/09/14