[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 05/25] qemu-img rebase: Open new backing file read-o
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PATCH 05/25] qemu-img rebase: Open new backing file read-only |
Date: |
Wed, 8 Sep 2010 15:29:22 +0200 |
We never write to a backing file, so opening rw is useless. It just means that
you can't rebase on top of a file for which you don't have write permissions.
Signed-off-by: Kevin Wolf <address@hidden>
---
qemu-img.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index e300f91..d2a978b 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -1286,7 +1286,7 @@ static int img_rebase(int argc, char **argv)
}
bs_new_backing = bdrv_new("new_backing");
- ret = bdrv_open(bs_new_backing, out_baseimg, BDRV_O_FLAGS |
BDRV_O_RDWR,
+ ret = bdrv_open(bs_new_backing, out_baseimg, BDRV_O_FLAGS,
new_backing_drv);
if (ret) {
error("Could not open new backing file '%s'", out_baseimg);
--
1.7.2.2
- [Qemu-devel] [PULL v2 00/25] Block patches, Kevin Wolf, 2010/09/08
- [Qemu-devel] [PATCH 06/25] vvfat: fat_chksum(): fix access above array bounds, Kevin Wolf, 2010/09/08
- [Qemu-devel] [PATCH 17/25] scsi: fix and improve debug prints, Kevin Wolf, 2010/09/08
- [Qemu-devel] [PATCH 15/25] scsi-disk: return CHECK CONDITION for unknown page codes in the MODE SENSE command, Kevin Wolf, 2010/09/08
- [Qemu-devel] [PATCH 22/25] raw-posix: improve detection of scsi-generic devices, Kevin Wolf, 2010/09/08
- [Qemu-devel] [PATCH 25/25] qcow2: Remove unnecessary flush after L2 write, Kevin Wolf, 2010/09/08
- [Qemu-devel] [PATCH 14/25] scsi-disk: fix the block descriptor returned by the MODE SENSE command, Kevin Wolf, 2010/09/08
- [Qemu-devel] [PATCH 18/25] qemu-io: Make alloc output useful when nb_sectors=1, Kevin Wolf, 2010/09/08
- [Qemu-devel] [PATCH 02/25] virtio-blk: Fix migration of queued requests, Kevin Wolf, 2010/09/08
- [Qemu-devel] [PATCH 05/25] qemu-img rebase: Open new backing file read-only,
Kevin Wolf <=
- [Qemu-devel] [PATCH 24/25] block: Fix BDRV_O_CACHE_MASK, Kevin Wolf, 2010/09/08
- [Qemu-devel] [PATCH 20/25] Improve ATA IDENTIFY word 64 contents., Kevin Wolf, 2010/09/08
- [Qemu-devel] [PATCH 23/25] qemu-img convert: Use cache=unsafe for output image, Kevin Wolf, 2010/09/08
- [Qemu-devel] [PATCH 21/25] scsi-disk: add some optional scsi commands, Kevin Wolf, 2010/09/08
- [Qemu-devel] [PATCH 07/25] nbd: Introduce NBD named exports., Kevin Wolf, 2010/09/08
- [Qemu-devel] [PATCH 19/25] raw-posix: Don't use file name for host_cdrom detection on Linux, Kevin Wolf, 2010/09/08
- [Qemu-devel] [PATCH 03/25] block: Fix image re-open in bdrv_commit, Kevin Wolf, 2010/09/08
- [Qemu-devel] [PATCH 11/25] scsi-disk: fix the mode data length field returned by the MODE SENSE command, Kevin Wolf, 2010/09/08
- [Qemu-devel] [PATCH 12/25] scsi-disk: fix the mode data header returned by the MODE SENSE(10) command, Kevin Wolf, 2010/09/08
- [Qemu-devel] [PATCH 09/25] monitor: make 'info snapshots' show only fully available snapshots, Kevin Wolf, 2010/09/08