Re: [Qemu-devel] [PATCH v5 00/10] initial spice support.

[Blue Swirl]

On Tue, Aug 31, 2010 at 4:22 PM, Anthony Liguori <address@hidden> wrote:
> On 08/31/2010 09:32 AM, Gerd Hoffmann wrote:
>>
>>   Hi,
>>
>> Here comes v5 of the iniial spice support patch series.
>>
>
> Reviewed-by: Anthony Liguori <address@hidden>
>
> For the whole series.
>
> Once folks have gotten a chance to review it a day or two more, I'll pull
> the repo if there are no issues.

Looks fine to me too, though the fsdev patch seems to be unrelated.

>
> Regards,
>
> Anthony Liguori
>
>>  * Detect spice in configure, Makefile windup.
>>  * Support for keyboard, mouse and tablet.
>>  * Support for simple display output (works as DisplayChangeListener,
>>    plays with any gfx card, sends simple draw commands to update
>>    dirty regions).
>>
>> Note that this patch series does *not* yet contain the qxl paravirtual
>> gfx card.  That will come as part of a additional patch series after
>> sorting the vgabios support.
>>
>> The patches are also available in the git repository at:
>>   git://anongit.freedesktop.org/spice/qemu submit.5
>>
>> Changes since v4:
>>   * Code style fixups.
>>   * Small bug fix (display_remote not being set when configuring
>>     spice via config file).
>>
>> Changes since v3:
>>   * Drop global spice_server variable, provide a thin wrapper function
>>     instead so spice interfaces can be registered without needing
>>     spice_server.
>>   * Update locking comments.
>>
>> Changes since v2:
>>   * Add copyright headers to the files.
>>   * Add dprint for debug logging.
>>   * Add mapping for buttons and leds.
>>   * Add comments for locking+threads.
>>   * Drop includes which qemu-common.h brings in.
>>   * Compile -spice switch unconditionally.
>>   * Hook up spice init using module.h, drop #ifdefs.
>>   * Misc minor tweaks.
>>
>>
>> *** BLURB HERE ***
>>
>> Gerd Hoffmann (10):
>>   Use display types for local display only.
>>   Use machine_init() to register virtfs config options.
>>   add pflib: PixelFormat conversion library.
>>   configure: add logging
>>   add spice into the configure file
>>   spice: core bits
>>   spice: add keyboard
>>   spice: add mouse
>>   spice: simple display
>>   spice: add tablet support
>>
>>  Makefile.objs      |    3 +
>>  configure          |   42 +++++-
>>  fsdev/qemu-fsdev.c |    9 +
>>  pflib.c            |  213 +++++++++++++++++++++++++++
>>  pflib.h            |   20 +++
>>  qemu-config.c      |   18 +++
>>  qemu-config.h      |    1 +
>>  qemu-options.hx    |   21 +++
>>  sysemu.h           |    1 -
>>  ui/qemu-spice.h    |   41 +++++
>>  ui/spice-core.c    |  189 ++++++++++++++++++++++++
>>  ui/spice-display.c |  412
>> ++++++++++++++++++++++++++++++++++++++++++++++++++++
>>  ui/spice-display.h |   69 +++++++++
>>  ui/spice-input.c   |  217 +++++++++++++++++++++++++++
>>  vl.c               |   50 +++++--
>>  15 files changed, 1287 insertions(+), 19 deletions(-)
>>  create mode 100644 pflib.c
>>  create mode 100644 pflib.h
>>  create mode 100644 ui/qemu-spice.h
>>  create mode 100644 ui/spice-core.c
>>  create mode 100644 ui/spice-display.c
>>  create mode 100644 ui/spice-display.h
>>  create mode 100644 ui/spice-input.c
>>
>>
>>
>
>
>