[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 6/6] scsi-disk: fix the check of the DBD bit in t
From: |
Bernhard Kohl |
Subject: |
[Qemu-devel] [PATCH v3 6/6] scsi-disk: fix the check of the DBD bit in the MODE SENSE command |
Date: |
Tue, 31 Aug 2010 14:08:27 +0200 |
The DBD bit does not work as expected.
SCSI-Spec:
http://ldkelley.com/SCSI2/SCSI2/SCSI2-08.html#8.2.10
"A disable block descriptors (DBD) bit of zero indicates that the target
may return zero or more block descriptors in the returned MODE SENSE
data (see 8.3.3), at the target's discretion. A DBD bit of one
specifies that the target shall not return any block descriptors in the
returned MODE SENSE data."
Signed-off-by: Bernhard Kohl <address@hidden>
---
hw/scsi-disk.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index 44f99b0..0c90c77 100644
--- a/hw/scsi-disk.c
+++ b/hw/scsi-disk.c
@@ -655,7 +655,7 @@ static int scsi_disk_emulate_mode_sense(SCSIRequest *req,
uint8_t *outbuf)
}
bdrv_get_geometry(s->bs, &nb_sectors);
- if ((~dbd) & nb_sectors) {
+ if (!dbd && nb_sectors) {
if (req->cmd.buf[0] == MODE_SENSE) {
outbuf[3] = 8; /* Block descriptor length */
} else { /* MODE_SENSE_10 */
--
1.7.2.2
- [Qemu-devel] [PATCH v3 0/6] scsi-disk: improve the emulation of the MODE SENSE command, Bernhard Kohl, 2010/08/31
- [Qemu-devel] [PATCH v3 2/6] scsi-disk: fix the mode data header returned by the MODE SENSE(10) command, Bernhard Kohl, 2010/08/31
- [Qemu-devel] [PATCH v3 6/6] scsi-disk: fix the check of the DBD bit in the MODE SENSE command,
Bernhard Kohl <=
- [Qemu-devel] [PATCH v3 4/6] scsi-disk: fix the block descriptor returned by the MODE SENSE command, Bernhard Kohl, 2010/08/31
- [Qemu-devel] [PATCH v3 5/6] scsi-disk: return CHECK CONDITION for unknown page codes in the MODE SENSE command, Bernhard Kohl, 2010/08/31
- [Qemu-devel] [PATCH v3 1/6] scsi-disk: fix the mode data length field returned by the MODE SENSE command, Bernhard Kohl, 2010/08/31
- [Qemu-devel] [PATCH v3 3/6] scsi-disk: respect the page control (PC) field in the MODE SENSE command, Bernhard Kohl, 2010/08/31
- [Qemu-devel] Re: [PATCH v3 0/6] scsi-disk: improve the emulation of the MODE SENSE command, Kevin Wolf, 2010/08/31