|
From: | Avi Kivity |
Subject: | Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments |
Date: | Sun, 22 Aug 2010 23:15:39 +0300 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.8) Gecko/20100806 Fedora/3.1.2-1.fc13 Thunderbird/3.1.2 |
On 08/19/2010 09:29 PM, Blue Swirl wrote:
Just to be sure I follow, are you suggesting we relax all of the bracing rule, or just the part about braces around single line statements? I'd be happy to write up a patch for the latter.I'd rather not relax the rules but find a solution so that the rules work.
I happen to like the single line braces rule. That is, I don't like how the code looks (I dislike punctuation generally), but I like the consistency and I like how patches that add or remove a line are easy to read.
My preference would be: new code has to adhere to the new style.Perhaps we can have a bot subscribed to the list issue auto-reviews if things are incorrect.
-- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.
[Prev in Thread] | Current Thread | [Next in Thread] |