qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCHv2] Fix USB mouse Set_Protocol behavior


From: Kevin O'Connor
Subject: [Qemu-devel] [PATCHv2] Fix USB mouse Set_Protocol behavior
Date: Mon, 2 Aug 2010 11:30:16 -0400
User-agent: Mutt/1.5.20 (2009-12-10)

The QEMU USB mouse claims to support the "boot" protocol
(bInterfaceSubClass is 1).  However, the mouse rejects the
Set_Protocol command.

The qemu mouse does support the "boot" protocol specification, so a
simple fix is to enable the Set_Protocol request.

Signed-off-by: Kevin O'Connor <address@hidden>
---
Changes v1->v2:
  Add signed-off-by line.
---
 hw/usb-hid.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/usb-hid.c b/hw/usb-hid.c
index 882d933..d54823d 100644
--- a/hw/usb-hid.c
+++ b/hw/usb-hid.c
@@ -791,13 +791,13 @@ static int usb_hid_handle_control(USBDevice *dev, int 
request, int value,
             goto fail;
         break;
     case GET_PROTOCOL:
-        if (s->kind != USB_KEYBOARD)
+        if (s->kind != USB_KEYBOARD && s->kind != USB_MOUSE)
             goto fail;
         ret = 1;
         data[0] = s->protocol;
         break;
     case SET_PROTOCOL:
-        if (s->kind != USB_KEYBOARD)
+        if (s->kind != USB_KEYBOARD && s->kind != USB_MOUSE)
             goto fail;
         ret = 0;
         s->protocol = value;
-- 
1.7.2




reply via email to

[Prev in Thread] Current Thread [Next in Thread]