[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help
From: |
Bruce Rogers |
Subject: |
Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help |
Date: |
Tue, 27 Jul 2010 07:11:21 -0600 |
>>> On 7/27/2010 at 04:26 AM, "Daniel P. Berrange" <address@hidden> wrote:
> On Wed, Jul 21, 2010 at 02:32:28PM -0600, Bruce Rogers wrote:
>> Libvirt parses qemu help output to determine qemu features. In particular
>> it probes for the following: "cache=writethrough|writeback|none". The
>> addition of the unsafe cache mode was inserted within this string, as
>> opposed to being added to the end, which impacted libvirt's probe.
>> Unbreak libvirt by keeping the existing cache modes intact and add
>> unsafe to the end.
>
> We have inverted the check we made so that instead of doing a positive
> check for the new syntax, we do a negative check for the old syntax,
> avoiding this problem. Of couse any existing deployed livirt will still
> be broken with latest QEMU, but the previous QEMU version string change
> mean that is already the case for any libvirt < 0.8.2
>
> Daniel
This seems like a quite reasonable resolution to me.
Thanks!
Bruce
- Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help, (continued)
- Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help, Markus Armbruster, 2010/07/27
- Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help, Avi Kivity, 2010/07/26
- Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help, Anthony Liguori, 2010/07/26
- Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help, Avi Kivity, 2010/07/26
- [Qemu-devel] Re: [PATCH] move 'unsafe' to end of caching modes in help, Juan Quintela, 2010/07/26
- Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help, Kevin Wolf, 2010/07/27
Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help, Luiz Capitulino, 2010/07/22
Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help, Daniel P. Berrange, 2010/07/27
- Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help,
Bruce Rogers <=