[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 01/13] blockdev: Clean up how readonly persists a
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v2 01/13] blockdev: Clean up how readonly persists across virtual media change |
Date: |
Tue, 6 Jul 2010 14:08:44 +0200 |
Since commit cb4e5f8e, monitor command change makes the new media
readonly iff the type hint is BDRV_TYPE_CDROM, i.e. the drive was
created with media=cdrom. The intention is to avoid changing a block
device's read-only-ness. However, BDRV_TYPE_CDROM is only a hint. It
is currently sufficent for read-only. But it's not necessary, and it
may not remain sufficient.
Use bdrv_is_read_only() instead.
Signed-off-by: Markus Armbruster <address@hidden>
---
blockdev.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index cecde2b..cca3eec 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -589,7 +589,7 @@ int do_change_block(Monitor *mon, const char *device,
if (eject_device(mon, bs, 0) < 0) {
return -1;
}
- bdrv_flags = bdrv_get_type_hint(bs) == BDRV_TYPE_CDROM ? 0 : BDRV_O_RDWR;
+ bdrv_flags = bdrv_is_read_only(bs) ? 0 : BDRV_O_RDWR;
if (bdrv_open(bs, filename, bdrv_flags, drv) < 0) {
qerror_report(QERR_OPEN_FILE_FAILED, filename);
return -1;
--
1.6.6.1
- [Qemu-devel] [PATCH v2 11/13] ide: Make ide_init_drive() return success, (continued)
- [Qemu-devel] [PATCH v2 11/13] ide: Make ide_init_drive() return success, Markus Armbruster, 2010/07/06
- [Qemu-devel] [PATCH v2 07/13] error: New qemu_opts_loc_restore(), Markus Armbruster, 2010/07/06
- [Qemu-devel] [PATCH v2 09/13] ide: Improve error messages, Markus Armbruster, 2010/07/06
- [Qemu-devel] [PATCH v2 04/13] fdc: Reject unimplemented error actions, Markus Armbruster, 2010/07/06
- [Qemu-devel] [PATCH v2 05/13] qdev: Don't hw_error() in qdev_init_nofail(), Markus Armbruster, 2010/07/06
- [Qemu-devel] [PATCH v2 01/13] blockdev: Clean up how readonly persists across virtual media change,
Markus Armbruster <=
- [Qemu-devel] [PATCH v2 02/13] block migration: Fix test for read-only drive, Markus Armbruster, 2010/07/06
- [Qemu-devel] [PATCH v2 03/13] raw-posix: Fix test for host CD-ROM, Markus Armbruster, 2010/07/06
- [Qemu-devel] [PATCH v2 06/13] scsi: Reject unimplemented error actions, Markus Armbruster, 2010/07/06