[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 0/4] introduce NEED_GLOBAL_ENV
From: |
Blue Swirl |
Subject: |
[Qemu-devel] Re: [PATCH 0/4] introduce NEED_GLOBAL_ENV |
Date: |
Mon, 28 Jun 2010 17:54:23 +0000 |
On Mon, Jun 28, 2010 at 5:17 PM, Paolo Bonzini <address@hidden> wrote:
> Let's start the cleanups from the feature required by Blue Swirl.
> I also include here a baby step towards removing eminently TCG-related
> stuff from cpu.h.
>
> After this series, only a bunch of files will include exec-all.h,
> instead of getting it indirectly from cpu.h.
>
> Note that (as sworn in the previous submission) exec.h is only included
> by files that need the global register variable (i.e. cpu-exec.c and
> target-*/op_helper.c), and this is the same subset that gets
> NEED_GLOBAL_ENV in this patchset.
>
> i386 and sparc have functions declared in cpu.h that are in op_helper.c.
> I checked that these do not need the global variable, but it would be
> nice to cleanup those too.
Maybe some of those could be moved to helper.c?
> Paolo Bonzini (4):
> remove unused stuff from */exec.h
> move cpu_pc_from_tb to target-*/exec.h
> remove exec-all.h inclusion from cpu.h
> require #define NEED_GLOBAL_ENV for files that need the global
> register variable
Good stuff. I had some comments to 1/4.
- Re: [Qemu-devel] Re: [PATCH 4/4] require #define NEED_GLOBAL_ENV for files that need the global register variable, (continued)
- Re: [Qemu-devel] Re: [PATCH 4/4] require #define NEED_GLOBAL_ENV for files that need the global register variable, Paul Brook, 2010/06/29
- Re: [Qemu-devel] Re: [PATCH 4/4] require #define NEED_GLOBAL_ENV for files that need the global register variable, Paolo Bonzini, 2010/06/29
- [Qemu-devel] Re: [PATCH 4/4] require #define NEED_GLOBAL_ENV for files that need the global register variable, Paolo Bonzini, 2010/06/29
- [Qemu-devel] Re: [PATCH 4/4] require #define NEED_GLOBAL_ENV for files that need the global register variable, Paul Brook, 2010/06/29
- [Qemu-devel] Re: [PATCH 4/4] require #define NEED_GLOBAL_ENV for files that need the global register variable, Paolo Bonzini, 2010/06/29
- Re: [Qemu-devel] Re: [PATCH 4/4] require #define NEED_GLOBAL_ENV for files that need the global register variable, Paul Brook, 2010/06/29
- [Qemu-devel] Re: [PATCH 4/4] require #define NEED_GLOBAL_ENV for files that need the global register variable, Blue Swirl, 2010/06/29
[Qemu-devel] [PATCH 1/4] remove unused stuff from */exec.h, Paolo Bonzini, 2010/06/28
[Qemu-devel] Re: [PATCH 0/4] introduce NEED_GLOBAL_ENV,
Blue Swirl <=