[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 12/13] QMP: Introduce qmp_check_input_obj()
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH 12/13] QMP: Introduce qmp_check_input_obj() |
|
Date: |
Wed, 23 Jun 2010 19:20:14 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Luiz Capitulino <address@hidden> writes:
> On Wed, 23 Jun 2010 17:23:54 +0200
> Markus Armbruster <address@hidden> wrote:
>
>> Luiz Capitulino <address@hidden> writes:
[...]
>> > + qerror_report(QERR_QMP_UNEXPECTED_INPUT_OBJECT_MEMBER,
>> > arg_name);
>>
>> Identifier's a bit on the long side, isn't it?
>
> Yes, suggestions?
What about omitting INPUT_OBJECT or at least OBJECT?
EXTRA instead of UNEXPECTED?
We could have
QERR_QMP_EXTRA_MEMBER
QERR_QMP_MISSING_MEMBER now: QERR_QMP_BAD_INPUT_OBJECT (I think)
QERR_QMP_BAD_MEMBER now: QERR_QMP_BAD_INPUT_OBJECT_MEMBER
[...]
- Re: [Qemu-devel] [PATCH 07/13] Monitor: handle optional '-' arg as a bool, (continued)
[Qemu-devel] [PATCH 13/13] QMP: Drop old input object checking, Luiz Capitulino, 2010/06/22
[Qemu-devel] [PATCH 09/13] QMP: New argument checker (second part), Luiz Capitulino, 2010/06/22
[Qemu-devel] [PATCH 12/13] QMP: Introduce qmp_check_input_obj(), Luiz Capitulino, 2010/06/22
[Qemu-devel] [PATCH 06/13] QDict: Introduce qdict_get_try_bool(), Luiz Capitulino, 2010/06/22