[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 2/6] cow: Use bdrv_(p)write_sync for metadata writes
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PATCH 2/6] cow: Use bdrv_(p)write_sync for metadata writes |
Date: |
Fri, 18 Jun 2010 17:03:25 +0200 |
Use bdrv_(p)write_sync to ensure metadata integrity in case of a crash.
While at it, correct the wrong usage of errno.
Signed-off-by: Kevin Wolf <address@hidden>
---
block/cow.c | 20 +++++++++++---------
1 files changed, 11 insertions(+), 9 deletions(-)
diff --git a/block/cow.c b/block/cow.c
index d146434..eedcc48 100644
--- a/block/cow.c
+++ b/block/cow.c
@@ -97,17 +97,18 @@ static inline int cow_set_bit(BlockDriverState *bs, int64_t
bitnum)
{
uint64_t offset = sizeof(struct cow_header_v2) + bitnum / 8;
uint8_t bitmap;
+ int ret;
- if (bdrv_pread(bs->file, offset, &bitmap, sizeof(bitmap)) !=
- sizeof(bitmap)) {
- return -errno;
+ ret = bdrv_pread(bs->file, offset, &bitmap, sizeof(bitmap));
+ if (ret < 0) {
+ return ret;
}
bitmap |= (1 << (bitnum % 8));
- if (bdrv_pwrite(bs->file, offset, &bitmap, sizeof(bitmap)) !=
- sizeof(bitmap)) {
- return -errno;
+ ret = bdrv_pwrite_sync(bs->file, offset, &bitmap, sizeof(bitmap));
+ if (ret < 0) {
+ return ret;
}
return 0;
}
@@ -116,10 +117,11 @@ static inline int is_bit_set(BlockDriverState *bs,
int64_t bitnum)
{
uint64_t offset = sizeof(struct cow_header_v2) + bitnum / 8;
uint8_t bitmap;
+ int ret;
- if (bdrv_pread(bs->file, offset, &bitmap, sizeof(bitmap)) !=
- sizeof(bitmap)) {
- return -errno;
+ ret = bdrv_pread(bs->file, offset, &bitmap, sizeof(bitmap));
+ if (ret < 0) {
+ return ret;
}
return !!(bitmap & (1 << (bitnum % 8)));
--
1.6.6.1
- [Qemu-devel] [PATCH 0/6] block: Add flush after metadata writes, Kevin Wolf, 2010/06/18
- [Qemu-devel] [PATCH 1/6] block: Add bdrv_(p)write_sync, Kevin Wolf, 2010/06/18
- [Qemu-devel] [PATCH 2/6] cow: Use bdrv_(p)write_sync for metadata writes,
Kevin Wolf <=
- [Qemu-devel] [PATCH 3/6] qcow: Use bdrv_(p)write_sync for metadata writes, Kevin Wolf, 2010/06/18
- [Qemu-devel] [PATCH 5/6] vmdk: Use bdrv_(p)write_sync for metadata writes, Kevin Wolf, 2010/06/18
- [Qemu-devel] [PATCH 4/6] qcow2: Use bdrv_(p)write_sync for metadata writes, Kevin Wolf, 2010/06/18
- [Qemu-devel] [PATCH 6/6] vpc: Use bdrv_(p)write_sync for metadata writes, Kevin Wolf, 2010/06/18
- Re: [Qemu-devel] [PATCH 0/6] block: Add flush after metadata writes, Stefan Hajnoczi, 2010/06/20