Re: [Qemu-devel] Re: [PATCH V4 2/3] qemu: Generic task offloading framework: threadlets

[Corentin Chary]

On Wed, Jun 16, 2010 at 5:52 PM, Anthony Liguori
<address@hidden> wrote:
> On 06/16/2010 10:47 AM, Corentin Chary wrote:
>>
>> I would need something like flush_threadlet_queue for the vnc server.
>> I need it in
>> vnc_disconnect(), vnc_dpy_resize() and vnc_dpy_cpy() so wait (and/or
>> abort) current
>> encoding jobs.
>>
>
> I'm not sure threadlets are the right thing for the VNC server.  The VNC
> server wants one dedicated thread.  Threadlets are a thread pool.  You could
> potentially use one thread per client but I doubt it would be worth it.
>
> At any rate, flushing the full queue is overkill.  You want to wait for your
> specific thread to terminate and you want to block execution until that
> happens.  IOW, you want to join the thread.
>

Oh right, I should have read the changelog more carefully, it's a
global queue now ...

Thanks,
-- 
Corentin Chary
http://xf.iksaif.net