qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH-V7 09/10] virtio-9p: Implement Security model fo


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH-V7 09/10] virtio-9p: Implement Security model for mknod
Date: Mon, 14 Jun 2010 16:04:51 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100423 Lightning/1.0b1 Thunderbird/3.0.4

On 06/14/2010 03:34 PM, Venkateswararao Jujjuri (JV) wrote:
Mapped mode stores extended attributes in the user space of the extended
attributes. Given that the user space extended attributes are available
to regular files only, special files are created as regular files on the
fileserver and appropriate mode bits are added to the extended attributes.
This method presents all special files and symlinks as regular files on the
fileserver while they are represented as special files on the guest mount.

On Host/Fileserver:
-rw-------. 1 virfsuid virtfsgid 0 2010-05-11 09:36 afifo
-rw-------. 1 virfsuid virtfsgid 0 2010-05-11 09:32 blkdev
-rw-------. 1 virfsuid virtfsgid 0 2010-05-11 09:33 chardev

On Guest/Client:
prw-r--r-- 1 guestuser guestuser 0 2010-05-11 12:36 afifo
brw-r--r-- 1 guestuser guestuser 0, 0 2010-05-11 12:32 blkdev
crw-r--r-- 1 guestuser guestuser 4, 5 2010-05-11 12:33 chardev

In the passthrough securit model, specifal files are directly created
on the fileserver. But the user credential

Signed-off-by: Venkateswararao Jujjuri<address@hidden>
---
  hw/file-op-9p.h      |    2 +-
  hw/virtio-9p-local.c |   34 ++++++++++++++++++++++++++++++++--
  hw/virtio-9p.c       |   14 ++++++++++----
  3 files changed, 43 insertions(+), 7 deletions(-)


  static int local_mksock(FsContext *ctx2, const char *path)
diff --git a/hw/virtio-9p.c b/hw/virtio-9p.c
index 1a25e96..d276db3 100644
--- a/hw/virtio-9p.c
+++ b/hw/virtio-9p.c
@@ -160,9 +160,15 @@ static int v9fs_do_chmod(V9fsState *s, V9fsString *path, 
mode_t mode)
      return s->ops->chmod(&s->ctx, path->data,&cred);
  }

-static int v9fs_do_mknod(V9fsState *s, V9fsString *path, mode_t mode, dev_t 
dev)
+static int v9fs_do_mknod(V9fsState *s, V9fsCreateState *vs, mode_t mode,
+        dev_t dev)
  {

You've added this function *before* you actually declare V9fsCreateState which is happening way down before v9fs_post_create().

Did you actually build these patches before sending them to the list?

Regards,

Anthony Liguori




reply via email to

[Prev in Thread] Current Thread [Next in Thread]