[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] export tdb_hash()
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] export tdb_hash() |
Date: |
Wed, 9 Jun 2010 17:35:06 -0300 |
On Tue, 8 Jun 2010 12:31:38 +0530
Prerna Saxena <address@hidden> wrote:
> This exports tdb_hash() for use by tracing framework.
Suggest to rename it (eg. qemu_hash()) and move it to a better location, qdict
is not the best module to export such service.
>
> Signed-off-by: Prerna Saxena <address@hidden>
> ---
> qdict.c | 2 +-
> qdict.h | 2 ++
> 2 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/qdict.c b/qdict.c
> index 175bc17..5261872 100644
> --- a/qdict.c
> +++ b/qdict.c
> @@ -56,7 +56,7 @@ QDict *qobject_to_qdict(const QObject *obj)
> * tdb_hash(): based on the hash agorithm from gdbm, via tdb
> * (from module-init-tools)
> */
> -static unsigned int tdb_hash(const char *name)
> +unsigned int tdb_hash(const char *name)
> {
> unsigned value; /* Used to compute the hash value. */
> unsigned i; /* Used to cycle through random values. */
> diff --git a/qdict.h b/qdict.h
> index 5e5902c..d221c18 100644
> --- a/qdict.h
> +++ b/qdict.h
> @@ -59,4 +59,6 @@ int64_t qdict_get_try_int(const QDict *qdict, const char
> *key,
> int64_t err_value);
> const char *qdict_get_try_str(const QDict *qdict, const char *key);
>
> +/* Export tdb_hash() for use by trace framework */
> +unsigned int tdb_hash(const char *name);
> #endif /* QDICT_H */