Re: [Qemu-devel] [PATCH 10/22] machine: allow boards to specify default values and use it in isapc

[Gerd Hoffmann]

On 06/08/10 15:09, Anthony Liguori wrote:
> On 06/08/2010 03:03 AM, Gerd Hoffmann wrote:
> > > + .opts_default = (QemuOptValue[]) {
> > > + {
> > > + .name = "acpi",
> > > + .value = "on",
> > > + },
> >
> > Should be moved into a separate struct and just referenced as it is
> > identical for pc-0.*
>
> Would need to be macros because in future patches, things get more
> complicated. That may be worth it though.

Well, maybe not.  Later patches add the compat properties to that list, 
which are different for the pc-0.* versions, so you would have to split 
again ...

cheers
  Gerd