|
From: | Gerd Hoffmann |
Subject: | [Qemu-devel] Re: Do we still need the hack to set qdev id from NICInfo.name? |
Date: | Tue, 08 Jun 2010 11:03:47 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-2.fc12 Thunderbird/3.0.4 |
pci_dev = pci_create(bus, devfn, pci_nic_names[i]); dev =&pci_dev->qdev; if (nd->name) dev->id = qemu_strdup(nd->name); Blatant violation of the DeviceState abstraction. Which even carries a comment advising against this:
Do we still need this? Anybody wanting ID can use -device.
I think it is only used for -net nic,...,name=something. I think this predates working -device for nics. So, yes, it shouldn't be needed any more ...
cheers, Gerd
[Prev in Thread] | Current Thread | [Next in Thread] |