|
From: | Paul Brook |
Subject: | Re: [Qemu-devel] [PATCH 15/22] machine: make max_cpus a -machine option |
Date: | Tue, 8 Jun 2010 03:56:55 +0100 |
User-agent: | KMail/1.13.3 (Linux/2.6.33-2-amd64; KDE/4.4.3; x86_64; ; ) |
> max_cpus is complicated because it was used for multiple purposes. I don't see any such uses. > > This is a fundamental property/limitation of the hardware. Expect qemu to > > crash if the value is modified. > > In this case, the machine cores should be rejecting totally invalid > values to prevent crashes from occurring. My reading of realview does > not suggest that a crash would occur. Are you speaking in general terms > or do you think it will actually fail in realview? qemu_irq cpu_irq[4]; ... for (n = 0; n < smp_cpus; n++) { cpu_irq[n] = irqp[ARM_PIC_CPU_IRQ]; I'm pretty sure bad things will happen there if smp_cpus is > 4. Similar assumptions exist in apic.c, and probably others. Paul
[Prev in Thread] | Current Thread | [Next in Thread] |