[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 00/16] HPET cleanups, fixes, enhancements
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [PATCH 00/16] HPET cleanups, fixes, enhancements |
Date: |
Sun, 06 Jun 2010 11:12:20 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Blue Swirl wrote:
> On Sun, Jun 6, 2010 at 8:10 AM, Jan Kiszka <address@hidden> wrote:
>> Second round, specifically adressing:
>> - IRQMsg framework to refactor existing de-coalescing code
>> - RTC IRQ output as GPIO pin (routed depening on HPET or -no-hpet)
>> - ISA reservation for RTC IRQ
>>
>> If discussion around IRQMsg and de-coalescing happens to continue, I
>> would suggest to merge patches 1..7 as they are likely uncontroversial
>> and also fix bugs.
>
> Otherwise everything looks fine to me, but 10 and 11 had minor
> problems. Nice work!
Thanks for the quick feedback!
>
> I'd suppose one possible cleanup could be to use the message payload
> in place of apic_deliver_irq()?
Haven't looked into such things yet, the series is already long enough.
:) I could also imagine that we may avoid exporting the APIC MSI
functions for HPET use and instead provide a single MSI qemu_irq object,
pushing the vector information into the message payload.
Jan
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 12/16] hpet: Drop static state, (continued)
- [Qemu-devel] [PATCH 12/16] hpet: Drop static state, Jan Kiszka, 2010/06/06
- [Qemu-devel] [PATCH 14/16] vmstate: Add VMSTATE_STRUCT_VARRAY_UINT8, Jan Kiszka, 2010/06/06
- [Qemu-devel] [PATCH 15/16] hpet: Make number of timers configurable, Jan Kiszka, 2010/06/06
- [Qemu-devel] [PATCH 16/16] hpet: Add MSI support, Jan Kiszka, 2010/06/06
- [Qemu-devel] [PATCH 13/16] hpet: Add support for level-triggered interrupts, Jan Kiszka, 2010/06/06
- [Qemu-devel] [PATCH 08/16] Pass IRQ object on handler invocation, Jan Kiszka, 2010/06/06
- [Qemu-devel] Re: [PATCH 00/16] HPET cleanups, fixes, enhancements, Blue Swirl, 2010/06/06
- [Qemu-devel] Re: [PATCH 00/16] HPET cleanups, fixes, enhancements,
Jan Kiszka <=