[Qemu-devel] Re: [PATCH 08/13] qdev: Decouple qdev_prop_drive from DriveInfo

[Markus Armbruster]

Gerd Hoffmann <address@hidden> writes:

>   Hi,
>
>> +static void free_drive(DeviceState *dev, Property *prop)
>> +{
>> +    BlockDriverState **ptr = qdev_get_prop_ptr(dev, prop);
>> +
>> +    if (*ptr) {
>> +        blockdev_detach(*ptr, dev);
>> +    }
>> +}
>
>> @@ -1043,26 +1043,26 @@ static void scsi_destroy(SCSIDevice *dev)
>>       SCSIDiskState *s = DO_UPCAST(SCSIDiskState, qdev, dev);
>>
>>       scsi_disk_purge_requests(s);
>> -    drive_uninit(s->qdev.conf.dinfo);
>>   }
>
> Neat.  Commit message should better explain that though.

Point.  I'll try to improve it.