Re: [Qemu-devel] [PATCH] Fix console_write_ch on 64-bit big-endian hosts

[andrzej zaborowski]

On 2 June 2010 22:32, Anthony Liguori <address@hidden> wrote:
> On 06/02/2010 02:31 PM, andrzej zaborowski wrote:
>> It seems that what this really tries to do is like *dest =
>> leul_to_cpu(v) from bswap.h? (Or cpu_to_leul.. quite difficult to wrap
>> my head around it..)
>>
>
> Yeah, I think it possibly should be a leul_to_cpu with the function
> signature changed to take an unsigned long.
>
> But one thing I'm very confused about is why console_ch_t is an unsigned
> long vs. a uint32..

I guess it is to be same as the curses' chtype, so they can be used
interchangeably.  curses.c is literally the only user of console_ch_t
so it kind of makes sense.  The problem is that console.h tries to
abstract the type of output device curses is, and fails.  And the
abstraction is unnecessary because curses is the only such interface
there.

Cheers