[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qbus: fix memory leak in qbus_free()
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH] qbus: fix memory leak in qbus_free() |
Date: |
Wed, 02 Jun 2010 17:01:13 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Isaku Yamahata <address@hidden> writes:
> BusState::name is allocated in qbus_create_inplace().
> So it should be freed by qbus_free().
Correct.
> Signed-off-by: Isaku Yamahata <address@hidden>
> ---
> hw/qdev.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/hw/qdev.c b/hw/qdev.c
> index af17486..2845af5 100644
> --- a/hw/qdev.c
> +++ b/hw/qdev.c
> @@ -700,6 +700,7 @@ void qbus_free(BusState *bus)
> QLIST_REMOVE(bus, sibling);
> bus->parent->num_child_bus--;
> }
> + qemu_free((void*)bus->name);
> if (bus->qdev_allocated) {
> qemu_free(bus);
> }
Ugly, superfluous cast to void *.
Thanks!
- Re: [Qemu-devel] [PATCH] qbus: fix memory leak in qbus_free(),
Markus Armbruster <=