[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PULL] pci, vhost fixes
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] Re: [PULL] pci, vhost fixes |
Date: |
Tue, 1 Jun 2010 17:13:11 +0000 |
On Tue, Jun 1, 2010 at 5:32 AM, Markus Armbruster <address@hidden> wrote:
> Blue Swirl <address@hidden> writes:
>
>> On Mon, May 31, 2010 at 1:35 PM, Michael S. Tsirkin <address@hidden> wrote:
>>> On Mon, May 31, 2010 at 02:51:26PM +0200, Paolo Bonzini wrote:
>>>> On 05/30/2010 08:19 PM, Blue Swirl wrote:
>>>>> We have PRI*64 just for this purpose, so let's use them. The
>>>>> discussion about that was earlier.
>>>>
>>>> How does mingw matter for vhost-net specific code?
>>>>
>>>> Paolo
>>>
>>> Good point. That code is linux-only, so we are safe using %lld.
>>> By the time someone ports vhost to windows, there's a chance
>>> debian will update it's mingw. Blue Swirl?
>>
>> It's a good point, but there's also consistency: now no '%ll*' formats are
>> used.
>
> If it ain't broke, don't fix it. Especially not when the fix is ugly.
Fully agree. But because beauty is in the eye of the beholder, our
conclusions are probably different. ;-)