qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL] pci, vhost fixes


From: Blue Swirl
Subject: Re: [Qemu-devel] [PULL] pci, vhost fixes
Date: Sun, 30 May 2010 18:19:40 +0000

On Sun, May 30, 2010 at 6:05 PM, Michael S. Tsirkin <address@hidden> wrote:
> On Sun, May 30, 2010 at 04:56:11PM +0000, Blue Swirl wrote:
>> On Sun, May 30, 2010 at 3:50 PM, Michael S. Tsirkin <address@hidden> wrote:
>> > The following changes since commit 
>> > 259d5577ae546de27e25a40710f81aa031660de8:
>> >
>> >  lsi: Fix value overflow in request tag processing (2010-05-22 15:32:32 
>> > +0200)
>> >
>> > are available in the git repository at:
>> >  git://git.kernel.org/pub/scm/linux/kernel/git/mst/qemu.git pci
>> >
>> > Isaku Yamahata (4):
>> >      pci: clean up of pci_set_default_subsystem_id().
>> >      pci: add const to pci_is_express(), pci_config_size().
>> >      pci.h: remove unused constants.
>> >      msix: remove duplicated defines.
>> >
>> > Michael S. Tsirkin (1):
>> >      vhost: fix build broken by 0bfcd599e3f5c5679cc7d0165a0a1822e2f60de2
>>
>> Nack, see 29f91781bd300b228d9c38b9f6c1e0b6a38f25fb.
>
> Did you follow the discussion about that patch before applying?
> 29f91781bd300b228d9c38b9f6c1e0b6a38f25fb does not make sense
> to me, I think it should be reverted.
> we have long long value, let us just print with %ll.
> casting to uint64 and printing with PRi64 is silly.

We have PRI*64 just for this purpose, so let's use them. The
discussion about that was earlier.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]