[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 02/14] avoid using expr in configure
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH 02/14] avoid using expr in configure |
Date: |
Wed, 26 May 2010 16:08:17 +0200 |
Just a personal preference against duplicating hieroglyphics.
Signed-off-by: Paolo Bonzini <address@hidden>
---
configure | 11 +++++++++--
1 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index e8dd2ef..5a7cb6e 100755
--- a/configure
+++ b/configure
@@ -928,6 +928,13 @@ if test -z "$target_list" ; then
echo "No targets enabled"
exit 1
fi
+# see if system emulation was really requested
+case " $target_list " in
+ *"-softmmu "*) softmmu=yes
+ ;;
+ *) softmmu=no
+ ;;
+esac
feature_not_found() {
feature=$1
@@ -2282,7 +2289,7 @@ bsd)
esac
tools=
-if test `expr "$target_list" : ".*softmmu.*"` != 0 ; then
+if test "$softmmu" = yes ; then
tools="qemu-img\$(EXESUF) qemu-io\$(EXESUF) $tools"
if [ "$linux" = "yes" -o "$bsd" = "yes" -o "$solaris" = "yes" ] ; then
tools="qemu-nbd\$(EXESUF) $tools"
@@ -2298,7 +2305,7 @@ echo "TOOLS=$tools" >> $config_host_mak
roms=
if test \( "$cpu" = "i386" -o "$cpu" = "x86_64" \) -a \
"$targetos" != "Darwin" -a "$targetos" != "SunOS" -a \
- `expr "$target_list" : ".*softmmu.*"` != 0 ; then
+ "$softmmu" = yes ; then
roms="optionrom"
fi
echo "ROMS=$roms" >> $config_host_mak
--
1.6.6.1
- [Qemu-devel] [PATCH 00/14] configure --xyzdir options cleanup, Paolo Bonzini, 2010/05/26
- [Qemu-devel] [PATCH 11/14] introduce more --xyzdir options, Paolo Bonzini, 2010/05/26
- [Qemu-devel] [PATCH 13/14] move directory defaults earlier, Paolo Bonzini, 2010/05/26
- [Qemu-devel] [PATCH 07/14] rename CONFIG_QEMU_PREFIX, Paolo Bonzini, 2010/05/26
- [Qemu-devel] [PATCH 12/14] ignore unknown --xyzdir options, Paolo Bonzini, 2010/05/26
- [Qemu-devel] [PATCH 05/14] introduce sysconfsuffix, Paolo Bonzini, 2010/05/26
- [Qemu-devel] [PATCH 06/14] introduce confdir and confsuffix, Paolo Bonzini, 2010/05/26
- [Qemu-devel] [PATCH 10/14] expand ${prefix} in create_config, Paolo Bonzini, 2010/05/26
- [Qemu-devel] [PATCH 08/14] unify handling of xyzdir variables, Paolo Bonzini, 2010/05/26
- [Qemu-devel] [PATCH 02/14] avoid using expr in configure,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 09/14] move all directory entries in config-host.mak close, Paolo Bonzini, 2010/05/26
- [Qemu-devel] [PATCH 01/14] bail out early on invalid -cpu option, Paolo Bonzini, 2010/05/26
- [Qemu-devel] [PATCH 03/14] dyngen is long time gone, Paolo Bonzini, 2010/05/26
- [Qemu-devel] [PATCH 04/14] delete duplicate create_config case stanza, Paolo Bonzini, 2010/05/26
- [Qemu-devel] [PATCH 14/14] move computation of tools and roms outside of config-host.mak generation, Paolo Bonzini, 2010/05/26
- Re: [Qemu-devel] [PATCH 00/14] configure --xyzdir options cleanup, Richard Henderson, 2010/05/26