|
From: | Paul Brook |
Subject: | Re: [Qemu-devel] [RFT][PATCH 09/15] hpet/rtc: Rework RTC IRQ replacement by HPET |
Date: | Tue, 25 May 2010 12:23:14 +0100 |
User-agent: | KMail/1.13.3 (Linux/2.6.33-2-amd64; KDE/4.4.3; x86_64; ; ) |
> Paul Brook wrote: > >>> This is wrong. The hpet device should expose this as an IO pin. > >> > >> Will look into this. > >> > >> BTW, I just realized that the GPIO handling is apparently lacking > >> support for attaching an output to multiple inputs. Or am I missing > >> something? > > > > Use an explicit mux. > > > > Incidentally I suspect your handling of the ISA IRQs is broken. You may > > never have more than one source connected to a sink. Shared IRQ lines > > must be done explicitly. > > No, the other way around: one source (RTC) multiple sinks (HPET, ACPI). > Will probably draft a generic irq/gpio mux. I realise that. However I'd expect things to break if the guest OS devices to share an IRQ line between the HPET and some other device. Paul
[Prev in Thread] | Current Thread | [Next in Thread] |