qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 0/6] Make hpet a compile time option


From: Paul Brook
Subject: [Qemu-devel] Re: [PATCH 0/6] Make hpet a compile time option
Date: Mon, 24 May 2010 17:32:46 +0100
User-agent: KMail/1.13.3 (Linux/2.6.33-2-amd64; KDE/4.4.3; x86_64; ; )

> Notice that this patch was sent against hpet as one example, if we agree
> that this "way" of disabling devices is ok, we could disable more
> devices/have more flexibility.  Notice that in general, we (RHEL/KVM)
> are interested in a small subset of qemu devices.

IMO this patch is a backwards step.  The device models should be cleaned up so 
that you don't need to make a compile time decision.  You'll notice that a 
fair amount of effort has been put into making the device/system code less 
tightly coupled and less machine specific.  All inter-device interaction and 
links should be explicit. Changing from "PC with HPET" and "PC without HPET" 
should not require recompiling anything, and devices shouldn't need to know or 
care which they're part of.

Paul



reply via email to

[Prev in Thread] Current Thread [Next in Thread]