[Qemu-devel] [Bug 584143] Re: qemu fails to set hdd serial number

[C de-Avillez]

Marking Triaged/Medium. Debian has accepted the patch, and a new
(patched) package is in Unstable. May be considered for SRU-ing into
10.04 LTS, so nominating.

** Changed in: qemu-kvm (Ubuntu)
   Importance: Undecided => Medium

** Changed in: qemu-kvm (Ubuntu)
       Status: New => Triaged

** Also affects: qemu-kvm (Ubuntu Lucid)
   Importance: Undecided
       Status: New

-- 
qemu fails to set hdd serial number
https://bugs.launchpad.net/bugs/584143
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.

Status in QEMU: New
Status in “qemu-kvm” package in Ubuntu: Triaged
Status in “qemu-kvm” source package in Lucid: New
Status in “qemu-kvm” package in Debian: Unknown

Bug description:
The -drive ...,serial=xyz option is broken, at least in 0.12.  See Debian 
bug#573439, http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=573439 for details.

The proposed fix from the original reporter:

--- qemu-kvm-0.12.3+dfsg/vl.c   2010-02-26 11:34:00.000000000 +0900
+++ qemu-kvm-0.12.3+dfsg.old/vl.c       2010-03-11 02:26:00.134217787 +0900
@@ -2397,7 +2397,7 @@
     dinfo->on_write_error = on_write_error;
     dinfo->opts = opts;
     if (serial)
-        strncpy(dinfo->serial, serial, sizeof(serial));
+        strncpy(dinfo->serial, serial, sizeof(dinfo->serial));
     QTAILQ_INSERT_TAIL(&drives, dinfo, next);
     if (is_extboot) {
         extboot_drive = dinfo;