[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/22] tcg-i386: Tidy initialization of tcg_targ
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH 02/22] tcg-i386: Tidy initialization of tcg_target_call_clobber_regs. |
Date: |
Wed, 19 May 2010 08:46:44 +0200 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Tue, Apr 13, 2010 at 03:26:17PM -0700, Richard Henderson wrote:
> Setting the registers one by one is easier to read, and gets
> optimized by the compiler just the same.
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> tcg/i386/tcg-target.c | 11 ++++++-----
> 1 files changed, 6 insertions(+), 5 deletions(-)
Thanks, applied.
> diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c
> index f5c24f7..359f81b 100644
> --- a/tcg/i386/tcg-target.c
> +++ b/tcg/i386/tcg-target.c
> @@ -1365,11 +1365,12 @@ void tcg_target_init(TCGContext *s)
> #endif
>
> tcg_regset_set32(tcg_target_available_regs[TCG_TYPE_I32], 0, 0xff);
> - tcg_regset_set32(tcg_target_call_clobber_regs, 0,
> - (1 << TCG_REG_EAX) |
> - (1 << TCG_REG_EDX) |
> - (1 << TCG_REG_ECX));
> -
> +
> + tcg_regset_clear(tcg_target_call_clobber_regs);
> + tcg_regset_set_reg(tcg_target_call_clobber_regs, TCG_REG_EAX);
> + tcg_regset_set_reg(tcg_target_call_clobber_regs, TCG_REG_EDX);
> + tcg_regset_set_reg(tcg_target_call_clobber_regs, TCG_REG_ECX);
> +
> tcg_regset_clear(s->reserved_regs);
> tcg_regset_set_reg(s->reserved_regs, TCG_REG_ESP);
>
> --
> 1.6.6.1
>
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH 02/22] tcg-i386: Tidy initialization of tcg_target_call_clobber_regs.,
Aurelien Jarno <=