[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH v2 01/10] vnc: refactor set_encodings
From: |
Alexander Graf |
Subject: |
[Qemu-devel] Re: [PATCH v2 01/10] vnc: refactor set_encodings |
Date: |
Tue, 18 May 2010 20:18:09 +0200 |
On 18.05.2010, at 20:09, Corentin Chary wrote:
> On Tue, May 18, 2010 at 2:54 PM, Alexander Graf <address@hidden> wrote:
>> Corentin Chary wrote:
>>> Create a new set_encoding() function to remove
>>> duplicated code in set_encodings().
>>>
>>> Signed-off-by: Corentin Chary <address@hidden>
>>>
>>
>> Acked-by: Alexander Graf <address@hidden>
>>
>> Keep in mind that this still means that the last requested compression
>> algorithm is used, which is reverse according to spec.
>>
>
> I didn't notice that the loop was reversed, and that the right
> encoding was selected *before* my patch.
> I think the right thing to do is to reverse my previous patch and add
> a comment at the begining of the loop.
I don't see your patch reversing the logic?
Alex
- [Qemu-devel] Re: [PATCH v2 03/10] vnc: only use a single zlib stream, (continued)
- [Qemu-devel] Re: [PATCH v2 03/10] vnc: only use a single zlib stream, Anthony Liguori, 2010/05/18
- [Qemu-devel] Re: [PATCH v2 03/10] vnc: only use a single zlib stream, Alexander Graf, 2010/05/18
- [Qemu-devel] Re: [PATCH v2 03/10] vnc: only use a single zlib stream, Anthony Liguori, 2010/05/18
- [Qemu-devel] Re: [PATCH v2 03/10] vnc: only use a single zlib stream, Alexander Graf, 2010/05/18
- [Qemu-devel] Re: [PATCH v2 03/10] vnc: only use a single zlib stream, Anthony Liguori, 2010/05/18
[Qemu-devel] [PATCH v2 02/10] vnc: really call zlib if we want zlib, Corentin Chary, 2010/05/18
[Qemu-devel] [PATCH v2 01/10] vnc: refactor set_encodings, Corentin Chary, 2010/05/18
[Qemu-devel] [PATCH v2 10/10] vnc: update copyrights for vnc-encoding-tight.c, Corentin Chary, 2010/05/18
[Qemu-devel] [PATCH v2 04/10] vnc: adjust compression zstream level, Corentin Chary, 2010/05/18
[Qemu-devel] [PATCH v2 05/10] vnc: add basic tight support, Corentin Chary, 2010/05/18