[Qemu-devel] Re: [PATCH 1/2] [block]: Fix scsi-generic breakage in find_image_format()

[Christoph Hellwig]

On Sat, May 15, 2010 at 06:30:52AM -0700, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger <address@hidden>
> 
> This patch adds a special BlockDriverState->sg check in 
> block.c:find_image_format()
> after bdrv_file_open() -> block/raw-posix.c:hdev_open() has been called to 
> determine
> if we are dealing with a Linux host scsi-generic device or not.
> 
> The patch then returns the BlockDriver * from find_protocol(), skipping the 
> subsequent
> bdrv_read() and rest of find_image_format().

That's not quite correct as we don't want to expose formats directly.
Returning

        bdrv_find_format("raw");

should fix it for now, although I really hate having these special
cases in block.c.