[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] block: fix aio_flush segfaults for read-only pr
|
From: |
Christoph Hellwig |
|
Subject: |
Re: [Qemu-devel] [PATCH] block: fix aio_flush segfaults for read-only protocols (e.g. curl) |
|
Date: |
Sun, 16 May 2010 15:21:59 +0200 |
|
User-agent: |
Mutt/1.3.28i |
On Sun, May 16, 2010 at 02:59:57PM +0300, Avi Kivity wrote:
> Not all block format drivers expose an io_flush method (reasonable for
> read-only protocols), so calling io_flush there will immediately segfault.
>
> Fix by checking for the method's existence before calling it.
Looks good,
Reviewed-by: Christoph Hellwig <address@hidden>