[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] linux-user: use default mmap_min_addr 65536 whe
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH] linux-user: use default mmap_min_addr 65536 when /proc/sys/vm/mmap_min_addr cannot be read |
|
Date: |
Thu, 13 May 2010 09:59:24 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-3.fc13 Thunderbird/3.0.4 |
On 05/13/2010 06:17 AM, Martin Jansa wrote:
> @@ -2899,8 +2900,14 @@ int main(int argc, char **argv, char **envp)
> if (fscanf(fp, "%lu", &tmp) == 1) {
> mmap_min_addr = tmp;
> qemu_log("host mmap_min_addr=0x%lx\n", mmap_min_addr);
> + } else {
> + qemu_log("cannot read value from /proc/sys/vm/mmap_min_addr,
> assuming %d\n", MMAP_MIN_ADDR_DEFAULT);
> + mmap_min_addr = MMAP_MIN_ADDR_DEFAULT;
> }
> fclose(fp);
> + } else {
> + qemu_log("cannot open /proc/sys/vm/mmap_min_addr for reading,
> assuming %d\n", MMAP_MIN_ADDR_DEFAULT);
> + mmap_min_addr = MMAP_MIN_ADDR_DEFAULT;
> }
> }
Perhaps you can combine these two else clauses?
r~